https://bugzilla.redhat.com/show_bug.cgi?id=1174408 --- Comment #14 from Vratislav Podzimek <vpodzime@xxxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #13) > All plugin lib subpackages except -crypto depend on libbd_crypto.so.0 > (subpackage -utils). A similar thing for the -devel subpackages and > -utils-devel. They include <utils.h>. That makes splitting off the -utils > and -utils-devel packages a questionable decision. I think you mean libbd_utils.so.0 not libbd_crypto.so.0. The -utils and -utils-devel packages are subpackages because a 3rd party code could use them not because of the plugins. > > src/lib/blockdev.c also doesn't list the -utils lib as a plugin! The utils lib is not a plugin, it is a library that is not loaded with dlopen(). > > > > Explicit review and confirmation that the plugin libs are loaded via > name.so.$MAJOR_VER and not just name.so would have been very good. This is fixed in the recent version of the package. > > > > %files devel > > %{_libdir}/libblockdev.so > > %{_includedir}/blockdev/blockdev.h > > %{_includedir}/blockdev/plugins.h > > … > > Directory /usr/include/blockdev is not included anywhere. > > $ repoquery --whatprovides /usr/include/blockdev > $ > > https://fedoraproject.org/wiki/Packaging: > Guidelines#File_and_Directory_Ownership > https://fedoraproject.org/wiki/Packaging:UnownedDirectories Good catch, thanks! Fixing. > > > > %package lvm-devel > > Summary: Development files for the libblockdev-lvm plugin/library > > Requires: %{name}-lvm%{?_isa} = %{version}-%{release} > > Requires: %{name}-utils-devel > > Better would have been to add %{?_isa} also to the -utils-devel Requires. > Especially the linking step would need the arch-specific .so lib to be found. Another good catch, thanks! Also fixing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review