https://bugzilla.redhat.com/show_bug.cgi?id=1162234 Sinny Kumari <ksinny@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksinny@xxxxxxxxx --- Comment #5 from Sinny Kumari <ksinny@xxxxxxxxx> --- This is un-official review of the package Couple of points from me: * spec file name doesn't match with srpm name. spec file name should be nss-securepass.spec instead of nss_securepass.spec http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name * Running rpmlint on source package also gives warning "nss-securepass.src: W: summary-ended-with-dot C NSS library for SecurePass." To avoid it, remove trailing period(.) from summary. http://fedoraproject.org/wiki/Common_Rpmlint_issues#summary-ended-with-dot * Instead of using ./configure using macro %configure to avoid warning "nss_securepass.spec:26: W: configure-without-libdir-spec " * %license macro should be used instead of %doc for License files https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text %license LICENSE LICENSE_APACHE2 LICENSE_GNUGPL LICENSE_MIT * Instead of using %attr(0755,root,root) /usr/%{_lib}/*.so* try using %{_libdir} macro https://fedoraproject.org/wiki/Packaging:RPMMacros?rd=Packaging/RPMMacros * Spec file contains instruction to install shared libraries files. %attr(0755,root,root) /usr/%{_lib}/*.so* So, you need to add %post -p /sbin/ldconfig %postun -p /sbin/ldconfig http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries * Changelog should be as per Fedora guideline http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review