[Bug 1177009] Review Request: python-tempest-lib - OpenStack Functional Testing Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1177009



--- Comment #12 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Running "file" on the appropriate file gives:

$ file jquery.js
jquery.js: ASCII text, with very long lines, with CRLF line terminators

Then I launch dos2unix:

$ dos2unix jquery.js
dos2unix: Datei jquery.js wird ins Unix-Format umgewandelt …

And finally I get:

$ file jquery.js
jquery.js: ASCII text, with very long lines


I don't use fedora-review at all. I prefer launching certain commands, I don't
like the "automatic" way.


I'm a bit confused about the changelog warning:

python-tempest-lib.noarch: W: incoherent-version-in-changelog 0.0.2-1
['0.0.4-1.fc22', '0.0.4-1']

This is for the noarch package only, but not for srpm or spec file... Any idea?


Regarding the missing docs for the base package: I had a look at the sources,
and I've found some files which would be worth to be added there. The file
README.rst (now in the -doc subpackage) contains some basic info about the
package and should be moved to that, moreover HACKING.rst, AUTHORS, Changelog
and CONTRIBUTING.rst. Although we have the -doc subpackage, we should also feed
the user with docs without the need to have the -doc package installed. BTW, to
let the docs depend on the base package is unusual:

%package doc
Summary: Documentation for %{name}
Group: Documentation
Requires: %{name} = %{version}-%{release}

Drop the "Requires:" line. Imagine, someone is searching for info about
python-tempest-lib, let him be able to install the docs independently from the
package itself. Actually there is no extra requirement to read the docs, just a
text viewer and HTML browser.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]