https://bugzilla.redhat.com/show_bug.cgi?id=1185963 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dvratil@xxxxxxxxxx Flags| |needinfo?(dvratil@xxxxxxxxx | |m) --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok licensing: not ok 1. MUST use: # KDE e.V. may determine that future GPL versions are accepted License: GPLv2 or GPLv3 I'm only referencing aggregate GPL here, there is a mixture of both, so if you prefer, you can also do: # KDE e.V. may determine that future GPL versions are accepted # KDE e.V. may determine that future LGPL versions are accepted License: (GPLv2 or GPLv3) and (LGPLv2 or LGPLv3) sources: ok 283896b01e1d0a2bacf45498aeffefae kde-gtk-config-5.2.0.tar.xz scriptlets: ok macros: ok 2. SHOULD omit these bits: # not *required*, but very nice. allows support for instant changes, gtk3. Requires: xsettings-kde Obsoletes: kcm-gtk < 5 Provides: kcm-gtk = %{version}-%{release} until the interaction is better understood (ie, I don't think this one uses xsettings at all, and per irc conversation, we could keep the option open to keeping kcm-gtk alive) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review