[Bug 1168333] Review Request: vagrant-libvirt - Vagrant provider for libvirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1168333



--- Comment #14 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Michael, thanks for the review! A few comments from me ...

(In reply to Michael Adam from comment #10)
> [-]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/vagrant/gems/doc,
>      /usr/share/vagrant/gems/specifications, /usr/share/vagrant/gems/gems,
>      /usr/share/vagrant/gems, /usr/share/vagrant
>      --> TODO: fix vagrant RPM
> [-]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/vagrant/gems/doc,
>      /usr/share/vagrant/gems/specifications, /usr/share/vagrant,
>      /usr/share/vagrant/gems, /usr/share/vagrant/gems/gems
>      --> TODO: fix vagrant RPM


This should be fixed in vagrant-1.6.5-18.fc22:

http://koji.fedoraproject.org/koji/taskinfo?taskID=8721662

> Rpmlint
> -------
> Checking: vagrant-libvirt-0.0.24-1.fc22.noarch.rpm
>           vagrant-libvirt-doc-0.0.24-1.fc22.noarch.rpm
>           vagrant-libvirt-0.0.24-1.fc22.src.rpm
> vagrant-libvirt.noarch: E: explicit-lib-dependency libvirt-daemon-kvm
> --> INVALID - this is not a library.

This specifies driver which is going to be in use with vagrant-libvirt.
According to documentation, only kvm and qemu are supported ATM.

https://github.com/pradels/vagrant-libvirt#provider-options

This could be better to replace by Recommends probably, but that is not handled
by YUM.

> vagrant-libvirt.noarch: W: summary-not-capitalized C libvirt provider for
> vagrant
> --> fixed

libvirt is official name of the project if I am not mistaken. In this sense it
is false positive.

> I have myself addressed all issues above.
> The issues are addressed in the following SRPM:
> With these versions I am happy.

Thanks for the patches. I merged them into my version:

Spec URL: http://people.redhat.com/vondruch/vagrant-libvirt.spec
SRPM URL:
http://people.redhat.com/vondruch/vagrant-libvirt-0.0.24-2.fc22.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8721967


(In reply to James (purpleidea) from comment #13)
> .bashrc_vagrant

This is missing on purpose. Although it definitely provides useful utilities, I
am not convinced about they comprehensiveness and I am not convinced they
belong in this package. Vagrant itself would be better place, but I would argue
about inclusion as well.

Moreover, they have no upstream, no tests, no documentation, no specification
etc => sooner or later, they will break without notice.

If you are serious about them, please consider to convince some upstream to
include them in the package.

> vagrant-libvirt.pkla

This was replaced by 10-vagrant-libvirt.rules (although I am still not
convinced we should ship this file, since there are security concerns such as
bug 957300).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]