[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Josef Stribny <jstribny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> ---
* Extra space before a dot: 

"Dom and Selector assertions for Rails applications ."

* Wrong upstream URL:

https://github.com/rails/rails-dom-testing is the new official URL from which
the latest release comes from. Upstream should probably fix that in .gemspec.

Otherwise everything looks sane, package builds and runs, rpmlint does not
complain about anything meaningful. ==> APPROVED. Please fix the above before
pushing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]