https://bugzilla.redhat.com/show_bug.cgi?id=1185163 --- Comment #3 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- (In reply to Robert Mayr from comment #2) > Hi, I think it's quite good already, just a few comments and clarifying > questions, maybe just doubts from my side: > 1) I can see the pilas.desktop is in the Ubuntu directory only and you use > it as a separate source. Could you use an english description instead of > spanish inside? I remove debian directory in %prep, because it is unusable by fedora (it is the debian package) , so, I use as SourceX this files because them are not installed by default for the setup.py. Anyways I can talk with upstream for add them in MANIFEST.in in a next version. Yeah, sure. I can add an english description in SCM at least you require in the review. > 2) The pilas-icono.png doesn't work for me (corrupt file in the SRPM?) and > it is in utils/ Yeah, Is this now. I can use this now https://github.com/hugoruscitti/pilas/commit/f8066ade6ddf6adbc42dd709621a73fa1a21c024 > Is there any reason why you don't use it? > 3) I can see there is at least an html manual in data/ for pilasengine, but > you don't have it in the %files section. Do you want to add it or leave it > away because it's a GUI application? > Correct. it is a GUI application and it is not needed manual pages. usually man pages does make sense for a cli tools > The rest looks good to me, here is my review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review