[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1182261



--- Comment #17 from Sinny Kumari <ksinny@xxxxxxxxx> ---
Updated spec, srpm and koji build
SPEC Url -
https://github.com/sinnykumari/libabigail-package/raw/master/spec/libabigail.spec
SRPM Url -
https://github.com/sinnykumari/libabigail-package/raw/master/srpm/libabigail-1.0-0.3.20150114git63c81f0.fc21.src.rpm
Koji build - http://koji.fedoraproject.org/koji/taskinfo?taskID=8718756

(In reply to Parag AN(पराग) from comment #16)
> 1) Sinny, you are still not following correct %changelog guidelines. Please
> read http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs page. I
> don't see since last release what you have changed.

Sorry about not using new changelog entry after each update in spec file. I was
updating same changelog on every update because I don't wanted to have lot of
changelog entry being added before package being actually build. Now, I am
adding new entry for every spec file update. Also, will follow same for future.

> 2) Currently mock is failing for the package you submitted as the newer
> python-sphinx change has not yet published. The last rawhide published was
> on 23rd Jan. So, we need to wait till next rawhide is available that will
> add new package python-sphinx-latex.

When can I expect next rawhide being available?

> 3) I don't think info gets pulled automatically by yum. I removed info
> package from the system and tried to install locally built libabigail
> package and can see info package is not installed automatically.
> So, add those requires in -doc subpackage only. 

I am using Fedora KDE and in my system when I tried to remove already installed
info package, dependency was in such a way that it was trying to remove even
systemd and emoval fails. Due to that I didn't add explicit requires as info
for doc package. It may not be case for other desktop environment on which you
tested. So, keeping in mind I have added info as explicit requires. 

> 4) One more think I found. Generally I have not seen people specifying full
> subpackage names where the name starts with the main package name. I don't
> think you need to follow the subpackage names like "-n <pkgname>" where all
> subpackages start with the main package name. For example for devel
> subpackage, you can just write as

Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]