[Bug 1087895] Review Request: argparse4j - The command-line parser library based on Python's argparse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1087895

Gerard Ryan <gerard@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Gerard Ryan <gerard@xxxxxxx> ---
(In reply to gil cattaneo from comment #4)
> Spec URL: http://gil.fedorapeople.org/argparse4j.spec
> SRPM URL: http://gil.fedorapeople.org/argparse4j-0.4.4-2.fc20.src.rpm
> 
> - fix license field
> - remove bundled jquery

Thanks Gil, it looks good to me now, all issues have been fixed.

Source tarballs are identical, and here's spec diff:

[grdryn@localhost updated]$ diff -u ../srpm-unpacked/argparse4j.spec
argparse4j.spec 
--- ../srpm-unpacked/argparse4j.spec    2015-01-19 01:11:57.000000000 +0000
+++ argparse4j.spec    2015-01-24 17:50:29.696160080 +0000
@@ -1,8 +1,10 @@
 Name:          argparse4j
 Version:       0.4.4
-Release:       1%{?dist}
+Release:       2%{?dist}
 Summary:       The command-line parser library based on Python's argparse
-License:       MIT
+# files with ASL 2.0
src/main/java/net/sourceforge/argparse4j/impl/type/FileArgumentType.java
+# src/main/java/net/sourceforge/argparse4j/internal/TerminalWidth.java
+License:       ASL 2.0 and MIT
 URL:           http://argparse4j.sourceforge.net
 Source0:      
https://github.com/tatsuhiro-t/argparse4j/archive/%{name}-%{version}.tar.gz

@@ -52,6 +54,7 @@
 cd src/site/sphinx
 %{__make} %{?_smp_mflags} html PACKAGE_VERSION=%{version}
 rm -r _build/html/.buildinfo
+rm -r _build/html/_static/jquery.js

 %install
 %mvn_install
@@ -68,6 +71,10 @@
 %doc LICENSE.txt src/site/sphinx/_build/html/

 %changelog
+* Sat Jan 24 2015 gil cattaneo <puntogil@xxxxxxxxx> 0.4.4-2
+- fix license field
+- remove bundled jquery
+
 * Fri Jan 16 2015 gil cattaneo <puntogil@xxxxxxxxx> 0.4.4-1
 - update to 0.4.4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]