https://bugzilla.redhat.com/show_bug.cgi?id=1181317 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Unless you plan to submit this for old EPELs (<7) remove the folowing parts: - python_sitearch define - BuildRoot For python packages using setup.py this standard pattern is normally used: %build %{__python2} setup.py build %install %{__python2} setup.py install -O1 --skip-build --root=%{buildroot} New guidelines say that you should say (https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text): %files %license LICENSE.txt SRPM link does not link to the srpm, but to a page... This breaks tools like fedora-review. You should link to the raw file directly (add ?raw=true at the end of the link for example). python-setuptools-devel → python-setuptools >From the build: [WARNING] poppler headers not found, PDF indexation won't work [WARNING] wv2 not found, DOC indexation won't work [WARNING] libsoup not found, itools.web won't work Maybe you can add more build dependencies to enable this. (In reply to Reiner Rottmann from comment #0) > Spec URL: > https://raw.githubusercontent.com/rrottmann/rpmbuild/master/SPECS/python- > itools.spec > > SRPM URL: > https://github.com/rrottmann/rpmbuild/blob/master/SRPMS/python-itools-0.75.1- > 1.fc20.src.rpm > > Description: > > Please note, I am still a new rpm packager. My first rpm package is still in > review under bz#734248. > > I Had a look at http://fedoraproject.org/wiki/SIGs/Python#Package_requests > and saw the request to create a Fedora RPM package for itools: > > The itools library offers a collection of packages covering a wide > range of capabilities. Including support for many file formats (XML, > CSV, HTML, etc.), a virtual file system (itools.fs), the simple > template language (STL), an index and search engine, and much more. > > While this is my first package for a python library, I took the challenge > and created above SPEC/SRPM files. > > I checked it with rpmlint and got the following warnings: > > python-itools.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/python2.7/site-packages/itools/xml/doctype.c > /usr/lib64/python2.7/site-packages/itools/xml/arp.c > /usr/lib64/python2.7/site-packages/itools/xml/pyparser.c > /usr/lib64/python2.7/site-packages/itools/xml/parser.h > /usr/lib64/python2.7/site-packages/itools/web/soup.c > /usr/lib64/python2.7/site-packages/itools/xml/parser.c Are they used at runtime or are they just copied by mistake? Probably the latter, so just nuke them with 'find %{buildroot} \( -name *.[ch] -o -name .mailmap \) -delete'. > A development file (usually source code) is located in a non-devel package. > If > you want to include source code in your package, be sure to create a > development package. > > python-itools.x86_64: W: hidden-file-or-dir > /usr/lib64/python2.7/site-packages/itools/.mailmap > The file or directory is hidden. You should see if this is normal, and delete > it from the package if not. It should be removed (see above). ... > python-itools.x86_64: W: no-manual-page-for-binary ipkg-quality.py > Each executable in standard binary directories should have a man page. Should. But doesn't have to. You can try to file a request upstream, or generate a man page yourself, usign help2man. But please leave this until the end, this is a significant amount of work and just a "should", not "must". %doc files are copied into /usr/lib64/python2.7/site-packages/itools/. You should add an %exclude for them, or remove them after installation. Runing the programs does not seem to work: $ /usr/bin/ipkg-build.py Traceback (most recent call last): File "/usr/bin/ipkg-build.py", line 35, in <module> from itools.pkg import get_config, get_manifest, open_worktree ImportError: cannot import name open_worktree > python-itools.x86_64: W: file-not-in-%lang > /usr/lib64/python2.7/site-packages/itools/locale/en.mo > python-itools.x86_64: W: file-not-in-%lang > /usr/lib64/python2.7/site-packages/itools/locale/es.mo > python-itools.x86_64: W: file-not-in-%lang > /usr/lib64/python2.7/site-packages/itools/locale/fr.mo > python-itools.x86_64: W: file-not-in-%lang > /usr/lib64/python2.7/site-packages/itools/locale/it.mo > python-itools.x86_64: W: file-not-in-%lang > /usr/lib64/python2.7/site-packages/itools/locale/zh.mo > 1 packages and 0 specfiles checked; 0 errors, 23 warnings. Hm, I don't know about this, maybe somebody else can chime in. So the most significant thing is to get the scripts to work I think :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review