https://bugzilla.redhat.com/show_bug.cgi?id=1185014 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Sandro Mani from comment #1) > From the review (see below), two points: > MUST > [?]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > ==> I guess the location of /usr/lib/gap/pkg/atlasrep/doc/ is > predictated by gap, so this is probably a non-issue. I have marked /usr/lib/gap/pkg/atlasrep/doc as %docdir to partially address this. > SHOULD > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. Okay, I have sent an email to upstream asking them to add the license text in the next release. > Looking at the spec, unless I'm mistaken about the purpose of these, I think > you need: > Requires(pre): gap-core > Requires(postun): gap-core You're right! I've added that in all of the gap-pkg-* spec files. Good catch. > Not strictly related to this package, but I noticed this when uninstalling: > ------------------------------------- > Running transaction (shutdown inhibited) > Erasing : gap-pkg-atlasrep-1.5.0-1.fc22.noarch > 1/4 > Updating GAP workspace /var/lib/gap/workspace.gz: done. > Erasing : GAPDoc-1.5.1-5.fc21.noarch > 2/4 > Updating GAP workspace /var/lib/gap/workspace.gz: Error, failed to load > needed package `gapdoc' (version >= 1.2) called from > brk> true > brk> done. Oops. That's a bug in the gap and GAPDoc packages. I will push a fix for this to Rawhide shortly. New URLs: Spec URL: https://jjames.fedorapeople.org/gap-pkg-atlasrep/gap-pkg-atlasrep.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-atlasrep/gap-pkg-atlasrep-1.5.0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review