https://bugzilla.redhat.com/show_bug.cgi?id=1181793 --- Comment #4 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- Thanks for the comments! (In reply to Antonio Trande from comment #3) > - There is code licensed with BSD and involved in the compilation. Change the License to "MIT and BSD". Otherwise, it is a free license https://fedoraproject.org/wiki/Licensing > - It's not necessary to list documentation files in the -devel package > since it depends by the main one. I prefer to keep it for files that are not "really" required in -devel, e.g. one may want to create build chroots passing --excludedocs as an extra install rpm option > - Please, use %license macro. Done > - 'environment-modules' is a 'Requires' package. > 'mp' installs files in the '/usr/share/Modules' directory. Corrected. it was incorrectly set as BuildRequires, not Requires. > - There are some unused-direct-shlib-dependency warnings. It comes from CMakeLists.tst ---8<--- # Link with librt for clock_gettime (Linux on i386). find_library(RT_LIBRARY rt) if (RT_LIBRARY) target_link_libraries(mp ${RT_LIBRARY}) endif () ---8<--- But it generates two shared libraries, while it is only required for one of them: ---8<--- $ objdump -d /lib64/libmp.so|grep clock_gettime 0000000000016ab0 <clock_gettime@plt>: 16ebc: e8 ef fb ff ff callq 16ab0 <clock_gettime@plt> ---8<--- I think this is not a big issue, otherwise, Fedora would have --as-needed in __global_ldflags, but my experience is that one just trade a kind of problems for others with that... Anyway, I added -DCMAKE_SHARED_LINKER_FLAGS="%{__global_ldflags} -Wl,--as-needed" \ to mp.spec, so the rpmlint warning should no longer happen. > - Instructions to package %{_javadir}/jacop/jacop.jar file are missing. Added information to the spec, I would appreciate a review, did not ask earlier because it is optional :) # Waiting for review https://bugzilla.redhat.com/show_bug.cgi?id=1177191 Spec URL: https://pcpa.fedorapeople.org/mp.spec SRPM URL: https://pcpa.fedorapeople.org/mp-1.3.0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review