[Bug 1183218] Review Request: perl-Crypt-Random-TESHA2 - Random numbers using timer/schedule entropy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1183218



--- Comment #4 from Paul Howarth <paul@xxxxxxxxxxxx> ---
Review
======

rpmlint output
==============
perl-Crypt-Random-TESHA2.noarch: W: spelling-error %description -l en_US jitter
-> hitter, jotter, jitters
perl-Crypt-Random-TESHA2.src: W: spelling-error %description -l en_US jitter ->
hitter, jotter, jitters

checklist
=========
- rpmlint OK
- package and spec file naming OK
- package meets guidelines
- license is same as perl, OK for Fedora, spec matches
- upstream LICENSE file packaged
- spec file written in English and is legible
- source matches upstream
- package builds OK in mock for Rawhide x86_64
- buildreqs OK
- no locales, libraries etc. to worry about
- package is not intended to be relocatable
- directory ownership and permissions OK
- no duplicate files
- macro usage is consistent
- code, not content
- no large docs, docs don't affect runtime
- no sub-packages present or warranted
- not a GUI app, no desktop file needed
- filenames are all ASCII

notes
=====
BR: perl(Config) only seems to be used in examples/threads.pl so is probably
not needed

Consider using %license LICENSE for EPEL-7 and all Fedora releases

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]