https://bugzilla.redhat.com/show_bug.cgi?id=1178912 --- Comment #18 from Jan Pokorný <jpokorny@xxxxxxxxxx> --- > ===== SHOULD items ===== > > Generic: > [x]: Reviewer should test that the package builds in mock. > [ ]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. > [x]: Final provides and requires are sane (see attachments). > [x]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cairo-dock- > plug-ins-xfce , cairo-dock-plug-ins-kde , cairo-dock-plug-ins-webkit , > cairo-dock-plug-ins-unstable , cairo-dock-python2 , cairo-dock-python3 , > cairo-dock-ruby , cairo-dock-vala , cairo-dock-vala-devel something slightly related (perhaps unnecessary arch-specificity) is being discussed above > [x]: Package functions as described. > [x]: Latest version is packaged. > [x]: Package does not include license text files separate from upstream. > [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. > [x]: Scriptlets must be sane, if used. > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. > [ ]: Package should compile and build into binary rpms on all supported > architectures. > [ ]: %check is present and all tests pass. > [x]: Packages should try to preserve timestamps of original installed files. > [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file > [x]: Sources can be downloaded from URI in Source: tag > [x]: Buildroot is not present > [x]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > [x]: Dist tag is present (not strictly required in GL). > [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. > [x]: Uses parallel make %{?_smp_mflags} macro. > [x]: The placement of pkgconfig(.pc) files are correct. > [x]: SourceX is a working URL. > [x]: Spec use %global instead of %define unless justified. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review