[Bug 1185301] Review Request: gnome-builder - IDE for writing GNOME-based software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1185301

Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bochecha@xxxxxxxxxxxxxxxxx



--- Comment #3 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> ---
License tag is incorrect, if I checked correctly it should be:

    License:       GPLv3+ and GPLv2+ and LGPLv3+ and LGPLv2+ and MIT and
CC-BY-SA and CC0

You could add a comment just above the license tag explaining what makes it so
complex, like I had in the spec file for my Copr:

# Most of GNOME Builder is licensed under the GPLv3+.
#
# The following files are licensed under the GPLv2+:
#     - src/dialogs/gb-close-confirmation-dialog.c
#     - src/dialogs/gb-close-confirmation-dialog.h
#     - src/gedit/gedit-menu-stack-switcher.c
#     - src/gedit/gedit-menu-stack-switcher.h
#
# The following files are licensed under the LGPLv2+:
#     - data/styles/builder-dark.xml (seems like an error, the header speaks
about GtkSourceView)
#     - src/animation/gb-frame-source.c
#     - src/animation/gb-frame-source.h
#     - src/fuzzy/fuzzy.c
#     - src/fuzzy/fuzzy.h
#     - src/gd/gd-tagged-entry.c
#     - src/gd/gd-tagged-entry.h
#     - src/gedit/gedit-close-button.c
#     - src/gedit/gedit-close-button.h
#     - src/nautilus/nautilus-floating-bar.c
#     - src/nautilus/nautilus-floating-bar.h
#     - src/trie/trie.c
#     - src/trie/trie.h
#     - src/util/gb-cairo.c
#     - src/util/gb-cairo.h
#     - src/util/gb-glib.h
#     - src/util/gb-gtk.c
#     - src/util/gb-gtk.h
#
# The following files are licensed under the LGPLv3+:
#     - src/auto-indent/gb-source-auto-indenter.c
#     - src/auto-indent/gb-source-auto-indenter.h
#     - src/auto-indent/gb-source-auto-indenter-c.c
#     - src/auto-indent/gb-source-auto-indenter-c.h
#     - src/auto-indent/gb-source-auto-indenter-python.c
#     - src/auto-indent/gb-source-auto-indenter-python.h
#     - src/auto-indent/gb-source-auto-indenter-xml.c
#     - src/auto-indent/gb-source-auto-indenter-xml.h
#
# The following files are MIT licensed:
#     - src/resources/css/markdown.css
#     - src/resources/js/marked.js
#
# The following files are licensed under the CC-BY-SA license:
#     - data/icons/
#
# The following files are licensed under the CC0 license:
#     - data/org.gnome.Builder.appdata.xml
#     - data/html-preview.png

Other than that, please use %license for the COPYING file, rather than %doc.

Finally, that #VCS comment seems wrong, unless you're packaging cheese again.
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]