[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1182261



--- Comment #12 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
(In reply to Parag AN(पराग) from comment #9)
> => You need to fix the changelog version-release to 
> 1.0-0.1.git.20150114git63c81f0

The first git is redundant, just use:
%global checkout %{date}git%{git_revision}


> 5) I had a look at source archive and it contains approximately 2.9MB of
> .git directory which we don't need. So change the source generation step like
> 
> tar -cvzf %%{name}-%%{version}.tar.gz %%{name}-%%{version} --exclude .git
> 
> and generate new tarball, use it and submit new package for further review.

Probably easier to use "git archvie..." at this point. Something like:

# This tarball was constructed from pulling the source code of
# libabigail from its Git repository by doing:
#    git clone git://sourceware.org/git/libabigail.git
#    pushd libabigail
#    git archive --prefix %%{name}-%%{version}/ -o %%{name}-%%{version}.tar.gz
%%{git_revision}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]