https://bugzilla.redhat.com/show_bug.cgi?id=1183235 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Rpmlint complains about some things: $ rpmlint -i -v * kdeedu-data.src: I: checking kdeedu-data.src: I: checking-url https://projects.kde.org/projects/kde/kdeedu/kdeedu-data (timeout 10 seconds) kdeedu-data.src: W: invalid-url URL: https://projects.kde.org/projects/kde/kdeedu/kdeedu-data The read operation timed out The value should be a valid, public HTTP, HTTPS, or FTP URL. kdeedu-data.src:29: W: setup-not-quiet Use the -q option to the %setup macro to avoid useless build output from unpacking the sources. kdeedu-data.src: I: checking-url http://download.kde.org/stable/applications/14.12.1/src/kdeedu-data-14.12.1.tar.xz (timeout 10 seconds) kdeedu-data.noarch: I: checking kdeedu-data.noarch: I: checking-url https://projects.kde.org/projects/kde/kdeedu/kdeedu-data (timeout 10 seconds) kdeedu-data.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/integral_func.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: dangling-relative-symlink /usr/share/apps/kvtml ../../kde4/apps/kvtml The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/editplots.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/maximum.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/minimum.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/newpolar.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/newfunction.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/deriv_func.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/newparametric.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/functionhelp.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/resetview.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.noarch: W: gzipped-svg-icon /usr/share/icons/hicolor/scalable/actions/editconstants.svgz Not all desktop environments that support SVG icons support them gzipped (.svgz). Install the icon as plain uncompressed SVG. kdeedu-data.spec: I: checking kdeedu-data.spec:29: W: setup-not-quiet Use the -q option to the %setup macro to avoid useless build output from unpacking the sources. kdeedu-data.spec: I: checking-url http://download.kde.org/stable/applications/14.12.1/src/kdeedu-data-14.12.1.tar.xz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 16 warnings. The warning about the not downloadable tarball is false positive. I can download it using wget. Regarding the svgz icons, you should install them uncompressed. I don't know about the problems gzipped versions can cause, but the plain versions don't eat up that lots of disk space. It is usual to apply the -q switch to %setup, please do so. The dangling-relative-symlink warning can be ignored. You are using a kde4-related macro in the file list: $ rpm --eval %{_kde4_appsdir} /usr/share/kde4/apps Are you sure to use this here, although your package actually points to kf5? Your package installs icons in /usr/share/icons/hicolor, which is owned by hicolor-icon-theme. As far as I can see, that is not pulled in as runtime requirement: $ rpm -qpR ./kdeedu-data-14.12.1-1.fc22.noarch.rpm /bin/sh /bin/sh /bin/sh kde-filesystem rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 So you have to add "Requires: hicolor-icon-theme". For better understanding, most kde4 packages don't need it, because it is pulled in by kdelibs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review