[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1182261



--- Comment #9 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Few more fixes required for above updated package.

1) When you prepare updated package its a good practice to do koji scratch
build and if its a successful build then check rpmlint output for all generated
rpm files. Or you can use fedora-review tool on your own updated package.

rpmlint output on all generated rpm files
libabigail.src: W: spelling-error %description -l en_US abidiff -> abiding
libabigail.src: W: spelling-error %description -l en_US abicompat -> compatible
libabigail.src: W: spelling-error %description -l en_US abidw -> abide
libabigail.src: W: spelling-error %description -l en_US abilint -> ability
libabigail.src: W: spelling-error %description -l en_US applicatipon ->
application, supplication, applicator
libabigail.src: W: invalid-url Source0: libabigail-1.0.tar.gz
libabigail.x86_64: W: spelling-error %description -l en_US applicatipon ->
application, supplication, applicator
libabigail.x86_64: W: incoherent-version-in-changelog 1.0-0.1.git.63c81f0
['1.0-0.1.git.20150114git63c81f0.fc22', '1.0-0.1.git.20150114git63c81f0']
libabigail.x86_64: W: no-manual-page-for-binary abidiff
libabigail.x86_64: W: no-manual-page-for-binary abicompat
libabigail.x86_64: W: no-manual-page-for-binary abilint
libabigail.x86_64: W: no-manual-page-for-binary abidw
libabigail-devel.x86_64: W: only-non-binary-in-usr-lib
libabigail-devel.x86_64: W: no-documentation
libabigail-doc.x86_64: W: spelling-error Summary(en_US) texinfo -> tinfoil
libabigail-doc.x86_64: W: spelling-error Summary(en_US) html -> HTML, ht ml,
ht-ml
libabigail-doc.x86_64: W: spelling-error %description -l en_US texinfo ->
tinfoil
libabigail-doc.x86_64: W: spelling-error %description -l en_US html -> HTML, ht
ml, ht-ml
libabigail-doc.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libabigail-doc/_static/jquery.js
5 packages and 0 specfiles checked; 0 errors, 19 warnings.

=> You need to fix the changelog version-release to 
1.0-0.1.git.20150114git63c81f0

=> Then the wrong-file-end-of-line-encoding warning can be fixed by adding
BuildRequires: dos2unix
and at the end of %install
dos2unix doc/manuals/html/_static/jquery.js

Rest can be ignored.

2) I see you actually need libzip not gzip. You can add following
BuildRequires: libzip
to enable optional feature.

3) As per new guidelines
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text , you
need to use %license macro for license file instead of %doc
%license COPYING-LGPLV3

4) Follow the texinfo guidelines
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo

You have missing Requires lines and need to use preun (not postun)

5) I had a look at source archive and it contains approximately 2.9MB of .git
directory which we don't need. So change the source generation step like

tar -cvzf %%{name}-%%{version}.tar.gz %%{name}-%%{version} --exclude .git

and generate new tarball, use it and submit new package for further review.

6) Everytime you update the spec file, increase the release number tag (so next
will be "0.2.%{checkout}%{?dist}" and add corresponding changes information in
%changelog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]