[Bug 1121601] Review Request: rt - request tracker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1121601

Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #23 from Jason Tibbitts <tibbs@xxxxxxxxxxx> ---
Did you want me to work on the 4.2.9 version instead?  If we can have it in
Fedora it would be great, just so that we don't start out behind.

For selinux stuff, you _could_ make the relevant semanage call in %post, or
make a separate selinux subpackage that does nothing but call that.  Not sure
it's worth it; honestly I'd just document the one semanage call needed to fix
the policy problem and move on.  The package has nontrivial setup requirements
in any case.

Sorry, I didn't notice the indirect httpd dependency.  I didn't notice it was
installed at build time.  (My test scripts install the built packages in the
buildroot and notice any additional dependencies.)  Making it explicit helps in
any case.

I think that one test fails because it assumes the files will be under
*/share/html but they're really under *share/rt/html.  I think if you just
patch t/web/query_log.t and change this line:


$m->text_like(qr{share/html/autohandler:\d+}, "stack trace includes mason
components");
to
$m->text_like(qr{share/rt/html/autohandler:\d+}, "stack trace includes mason
components");

then all the tests will pass.  Pretty sure this is just a bug in the test
suite, assuming details about how the package was installed which it shouldn't.

At this point I think the 4.0.22 version is good to go, and I've set the flag
accordingly.  I will go ahead and look into the 4.2.9 version instead if you
like.  I don't know if it needs the same tweaks you made in comment 21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]