https://bugzilla.redhat.com/show_bug.cgi?id=1185002 Bug ID: 1185002 Summary: Review Request: appmenu-qt5 - Support for global DBus-exported application menu in Qt5 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: mario.blaettermann@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: https://mariobl.fedorapeople.org/Review/SPECS/appmenu-qt5.spec SRPM URL: https://mariobl.fedorapeople.org/Review/SRPMS/appmenu-qt5-0.3.0-r26.1.fc21.src.rpm Description: This is a different, Qt5-compatible approach of the existing appmenu-qt (https://launchpad.net/appmenu-qt). appmenu-qt5 is a Qt5 QPA theme plugin that adds support for application menus to Qt5 applications. This only works for Qt5 versions >= 5.2 currently. To enable the support, set QT_QPA_PLATFORMTHEME=appmenu-qt5 in your environment. Fedora Account System Username: mariobl I get this from rpmlint: appmenu-qt5.spec:40: W: rpm-buildroot-usage %build make %{?_smp_mflags} INSTALL_ROOT=$RPM_BUILD_ROOT $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may break short circuit builds. But I don't know another solution to make the install directory known to qmake-qt5. Moreover, I'm not sure about versioning. Ubuntu uses the same generated tarball for the package version 0.3.0 although I can't find that number anywhere in the source files. As far as I can evaluate, they use it only for distinction between the existing Qt4 version and the Qt5 package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review