https://bugzilla.redhat.com/show_bug.cgi?id=1180723 --- Comment #12 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For 0.3.5-1 * Builds - Your srpm does not build http://koji.fedoraproject.org/koji/taskinfo?taskID=8696816 - Parameterized macro (%autosetup) cannot be wrapped with bracket. - also %verify cannot be wrapped. * URL format - For specifying version, better to use %version so that you don't have to modify URL format when version is upgraded (this type of macro is better to use) - Also you can use %{version} in other place (using %version is common) * %{?_isa} specific depdendency on noarch packages - is not allowed because this makes that noarch packages non-arch-independent (%{?_isa} can be expanded into one specific architecture, and on other arch such "noarch" rpms cannot be installed) * %post - This %post script belongs to no packages (clufter binary rpm itself is not created) - Rather creating completion file beforehand and getting rid of %verify is preferred (for rpm -V). - And as actually this is done, I don't think this %post is needed * completion file - Using %{_sysconfdir}/bash_completion.d/ is obsolete. Move completion file to %{_datadir}/bash-completion/completions https://lists.fedoraproject.org/pipermail/devel/2013-March/180508.html - and have some package own %{_datadir}/bash-completion/ (and directories below) https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function * %doc - Files under %_datadir/doc , %_datadir/man are automatically marked as %doc and redundant %doc should be removed. * License - Files under doc/ are under GFDL so python-clufter should have "GPLv2+ and GFSL" license tag. * %files * python-clufter - %exclude %{_bindir}/clufter is redundant. % %files -n usage with having %{name}- prefix - %files -n clufter-cli is sufficient with "%files cli" - Similarly, %package lib-general is better than %package -n clufter-lib-general %check || : - The usage "|| :" here is the old craft and should not be used any longer (There was a discussion / decision about this long times ago - I no longer remember when) - For ${ret} rpmbuild invokes bash shell with "set -e", so if ./run-check exits with non-0 status rpmbuild will abort there, so ret=$? is not needed. * Some rpmlint stuff - Remove macro-in-comment rpmlint -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review