Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx OtherBugsDependingO|163776 | nThis| | Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-05-10 15:05 EST ------- (In reply to comment #18) > Updated to 0.8.23 > > Spec URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2.spec > SRPM URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2-0.8.23-1.src.rpm > > I have problems with campaign. First mission doesn't end. I'll ask upstream > what's going on. Hmm, I've just compared you're package with the mandrake package hosted on the homepage, and I noticed that mandrake uses autoreconf -f -i, you could try adding that to end of %prep instead of this hack: %{__sed} -i '1871d' configure touch -c -r aclocal.m4 configure configure.in You can also try commenting %patch0, the mandrake srpm doesn't have any patches. Maybe that will fix things. As said I would be happy to review this, but if it doesn't work, its little good. If all else fails downgrade to .22 or .21 Some other initial review remarks: Merge the -data package into the main, having a seperate data package when its in the same srpm is of no use. Move the icon from /usr/share/pixmaps to /usr/share/icons/hicolor/<size>/apps and add iconcache update scripts. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review