https://bugzilla.redhat.com/show_bug.cgi?id=1184446 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Suggestions: 1) There are many BuildRequires: and Requires: packages on single line, good to write them as one package per line like BuildRequires: python2-devel BuildRequires: python-setuptools BuildRequires: python-redis BuildRequires: python-sqlalchemy Requires: redis Requires: python-redis Requires: docker-io Requires: libguestfs-tools Requires: python-sqlalchemy Requires: python-paramiko 2) We now use specific macros python2 or python3, See http://fedoraproject.org/wiki/Packaging:Python#Macros 3) If this package is not for EPEL5 which I believe not then you can safely remove Group tag. 4) License is not clear. Only few source files show GPLv2+ whereas PKG-INFO and setup.py says just GPL and there is no supporting text file of license. Ask upstream to add license text file. 5) You need to add following in %prep after %setup # Remove upstream provided egg-info files rm -rf *.egg-info 6) we already have a macro for /usr/share %{_prefix}/share/tunir to %{_datadir}/tunir 7) Can we have python3 compatibility added in upstream? You know soon we are moving to use python3 as default. 8) Also, I don't think you need to remove *.py{c,o} files in %install -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review