[Bug 1131127] Review Request: safelease - legacy locking mechanism for VDSM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1131127



--- Comment #18 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
> Assignee: nobody@xxxxxxxxxxxxxxxxx → ybronhei@xxxxxxxxxx

As pointed out in comment 16, the bugzilla review tickets are assigned to _the
reviewer_, which in this case MUST be a reviewer who is also a packager
sponsor.
This is explained here:

  https://fedoraproject.org/wiki/Package_Review_Process#Reviewer

Parts of the process may be a bit confusing, but we've all started somewhere.

[...]

About these rpmlint W/E:

> safelease.src:38: W: macro-in-%changelog %libname
> safelease.src:38: W: macro-in-%changelog %name

You may want to escape them with a double '%%', so they are not expanded. Not
only will it make the %changelog comment more readable, expanded macros in
%changelog can cause problems. Not limited to garbage such as an expanded
%configure macro. ;)


> safelease.x86_64: E: zero-length /usr/share/doc/safelease/readme.md

Not really an Error, but if one doesn't want to package empty files, one is
better served with a guard somewhere in %prep or %install which would error out
once the file has non-zero length -> a reminder to add it or revisit the
packaging.


Any replies to comment 16?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]