[Bug 1183218] Review Request: perl-Crypt-Random-TESHA2 - Random numbers using timer/schedule entropy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1183218



--- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> ---
Quick comment: the conditional you've used for using the bundled
Statistics::Basic will trigger on Fedora, whilst I suspect you just wanted it
for EL6/7.

You have:
%if 0%{?rhel} <= 7

This is true of Fedora where %rhel is undefined.

I think you want something more like:
%if 0%{?rhel:1} && 0%{?rhel} <= 7

Or I suppose you could get away with:
%if 0%{?fedora}%{?rhel} <= 7
but that might suggest to readers that the package might build on ancient
Fedora versions.

Having said all that, I really think you should drop the bundling and request
branches of perl-Statistics-Basic for EPEL-6/7 and use those instead. I've
tried building the current devel version for EPEL-6 and that works with a minor
spec change:

--- a/perl-Statistics-Basic.spec
+++ b/perl-Statistics-Basic.spec
@@ -8,7 +8,7 @@ URL:            http://search.cpan.org/dist/Statistics-Basic/
 Source0:       
http://www.cpan.org/authors/id/J/JE/JETTERO/Statistics-Basic-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl
-BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
 # Run-time
@@ -43,11 +43,12 @@ my $correlation = correlation( [1 .. 3], [1 .. 3] );
 %setup -q -n Statistics-Basic-%{version}

 %build
-perl Makefile.PL INSTALLDIRS=perl NO_PACKLIST=1
+perl Makefile.PL INSTALLDIRS=perl
 make %{?_smp_mflags}

 %install
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+find $RPM_BUILD_ROOT -name .packlist -exec rm {} \;
 %{_fixperms} $RPM_BUILD_ROOT/*

 %check

EPEL-7 would also need perl-Number-Format branching, which I haven't tried but
wouldn't anticipate being a problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]