[Bug 1020456] Review Request: vagrant - an automation tool used to manage development environments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020456



--- Comment #31 from Michael Adam <madam@xxxxxxxxxx> ---
(In reply to Vít Ondruch from comment #28)
> (In reply to Michael Adam from comment #25)
> > [x]: Package must own all directories that it creates.
> >      Note: Directories without known owners: /usr/lib/rpm/macros.d,
> >      /usr/lib/rpm, /usr/share/bash-completion/completions, /usr/share/bash-
> >      completion
> >      ==> The correct thing to do seems to be to
> >          require bash_completion and rpm, but no other rpms seem to do that...
> 
> The package now owns the /usr/share/bash-completion, since it is one of the
> example in package guidelines ;) I don't think RPM is optional and we can't
> have a system without the macros.d directory, so I keep it as it is.

Ok, see previous comment.

> > [x]: Latest version is packaged.
> >      ==> it seems to have been a deliberate decision not to package
> >          the very new latest version (1.7.2),
> >          but a slighytly older version 1.6.5 instead.
> 
> I wanted to get this into Fedora ASAP and updates to the package would be
> just slow down for me and for reviewers as well. I don't think this is
> blocker.

OK.

> > vagrant.noarch: E: non-executable-script
> > /usr/share/bash-completion/completions/vagrant 0644L /bin/bash
> > ==> fixed by installing with different perms
> 
> I rather removed the shebang, since I don't think it has any merit to have
> this file executable.

Agreed!

> > vagrant.noarch: W: no-manual-page-for-binary vagrant
> > ==> TODO? maybe later?
> 
> Hopefully :)

;-)

> > A few minor issues are addressed by the patch to the specfile I'll attach next.
> 
> Thanks for the patch!
> 
> Here are updated .spec file and SRPM:
> 
> http://people.redhat.com/vondruch/vagrant.spec
> http://people.redhat.com/vondruch/vagrant-1.6.5-16.fc22.src.rpm
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=8672816

Thanks, I'm gonna take (final?) next look now.

Cheers - Michael

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]