[Bug 1178911] Review Request: cairo-dock - Light eye-candy fully themable animated dock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1178911



--- Comment #9 from Jan Pokorný <jpokorny@xxxxxxxxxx> ---
Thanks, spot!


Mamoru, some more points below:

Regarding the License tag vs BSD: there was an apparent mistake on my
side as I was considering all files within a source RPM, not binary RPMs.
"Better safe than sorry", but needless exercise (well, not sure how
common/sane is to relay on customizations of standard CMake modules,
but this is an upstream question).


>> For %changelog dates rpmlint
> - Well, I don't rememeber what date is correct any longer...
> So although it is true that date is wrong in some way, I don't want to
> fix them.

Accepted, I only wanted to point out that it is relatively a new feature
of RPM to complain any time a specfile with iffy dates is being parsed
and that this dirt under the carpet will keep exposing itself over
and over.


Could I please know your standpoint on:
- %check phase
- documenting the build order wrt. cairo-dock-plug-ins
  - side-question: will this get right automatically during mass rebuilds?

In the light of this review, I'll jump briefly on cairo-dock-plug-ins
part.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]