https://bugzilla.redhat.com/show_bug.cgi?id=225889 Tomas Hozza <thozza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Flags|needinfo?(thozza@xxxxxxxxxx | |) | Last Closed| |2015-01-19 08:06:11 --- Comment #4 from Tomas Hozza <thozza@xxxxxxxxxx> --- (In reply to Kamil Dudka from comment #2) > may be better > ============= > - 9 lines of the description are the same for htdig and htdig-web > subpackage; it would be good to define it as a macro, so that it can be > maintained at one place. macro added > - explicit BuildRequires for flex should be either commented, or better made > non-explicit I removed the explicit version. I don't know about the reasons for the version, however the version in Fedora is newer so it should not be needed. > - redundant BuildRequires for autoconf and automake (already required by > libtool) removed > - some patches lack link to upstream thread Upstream is dead for 8 years. Nothing will happen and most probably this is the last time someone is touching this package before it will be dropped from the distro in the future. Honestly I don't know the reasons behind those patches and it seems like a waste of time to try to investigate it. The last post on upstream devel list is from March 2005. > - hard-link creation deserves a comment (perhaps should be a symlink > instead?) I changed it to symbolic. > - %defattr(-,root,root) should be %defattr(-,root,root,-) fixed > - ldconfig is not called at all - I suggest to add following: > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig Added > - the option -r of rm may be omitted in the following commands > rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig/*.a > rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig/*.la > rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig_db/*.a > rm -rf $RPM_BUILD_ROOT%{_libdir}/htdig_db/*.la modified Fixed in htdig-3.2.0-0.20.b6.fc22 -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review