https://bugzilla.redhat.com/show_bug.cgi?id=1171624 --- Comment #15 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> --- > %files > %{_docdir}/%{name}/ReadMe.md > %license LICENSE > %{_libdir}/*.so.* In this package, a directory entry for %{_docdir}/%{name} is missing. https://fedoraproject.org/wiki/Packaging:UnownedDirectories > %files doc > %{_docdir}/%{name}/ReadMe.md > %license LICENSE > %{_docdir}/%{name}/ The line %{_docdir}/%{name}/ with or without a trailing-slash already includes %{_docdir}/%{name} (regardless of whether it's a directory or a file) and all its contents, if it's a directory. That makes the line %{_docdir}/%{name}/ReadMe.md superfluous. > %files devel > %{_libdir}/*.so > dir %{_libdir}/cmake/%{name}/ > %{_libdir}/cmake/%{name}/ > %{_includedir}/%{name}/ Similarly here. The %dir line includes *only* a directory entry for %{_libdir}/cmake/%{name}, but none its contents. The line %{_libdir}/cmake/%{name}/ with or without a trailing-slash includes the directory and its contents. That makes the %dir line superfluous. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories The "rpmls" command is very convenient for examining package contents. Give it a try. You can grep for "^d" and take a look at all directories in a package. That makes it easy to see whether parent/child directories are missing. Plus, directory %{_libdir}/cmake is not included yet. That's the following case, if you don't want to add a strict dependency on cmake: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function $ rpmls -p statismo-doc-0.10.1-5.fc21.noarch.rpm drwxr-xr-x /usr/share/doc/statismo -rw-r--r-- /usr/share/doc/statismo/LICENSE -rw-r--r-- /usr/share/doc/statismo/ReadMe.md drwxr-xr-x /usr/share/doc/statismo/html drwxr-xr-x /usr/share/licenses/statismo-doc -rw-r--r-- /usr/share/licenses/statismo-doc/LICENSE One can see the empty "html" directory and the duplicated LICENSE file. $ rpmls -p statismo-devel-0.10.1-5.fc21.x86_64.rpm|grep ^d drwxr-xr-x /usr/include/statismo drwxr-xr-x /usr/include/statismo/ITK drwxr-xr-x /usr/include/statismo/VTK drwxr-xr-x /usr/include/statismo/core drwxr-xr-x /usr/lib64/cmake/statismo Here there should be a 'd' entry for /usr/lib64/cmake as well. > .../BUILD/statismo-0.10.1/modules/core/include/StatismoUtils.h:142: > warning: the use of `tmpnam' is dangerous, better use `mkstemp' std::string tmpfilename = tmpnam(0); tmpfilename += extension; Just curious: Are these tmp files opened in a safe way everywhere just to avoid the potential threat? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review