https://bugzilla.redhat.com/show_bug.cgi?id=1151839 --- Comment #2 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> --- Consider pointing the optional fedora-review tool at this ticket: fedora-review -b 1151839 It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest files, and performs many checks on test-builds. Not limited to running rpmlint on all packages. > Version: 0 > Release: 0.1.20141012%{?dist} Seems you want to apply these guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Also, it will be very important to be aware of this: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Minor_release_bumps_for_old_branches > Source0: http://snowball.tartarus.org/dist/libstemmer_c.tgz snowball-c.src: W: file-size-mismatch libstemmer_c.tgz = 129592, http://snowball.tartarus.org/dist/libstemmer_c.tgz = 129584 > # patch to build shared modules; the upstream doesn't build shared modules' > Patch0: shared-module.patch Dangerous, if there is no collaboration with upstream. Who will ensure API/ABI stability? What about compatibility with other dists? Will you bump from libstemmer.so.0 to libstemmer.so.1 and libstemmer.so.N, increasing the risk that a future upstream release will reintroduce/reuse a SONAME you've used before? https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 > %build > make %{?_smp_mflags} https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > ln -s libstemmer.so.0.0.0 %{buildroot}%{_libdir}/libstemmer.so || : Why the '|| :'? You want the build to fail, if commands like this fail. With a proper %files section, it would fail later anyway. > http://snowball.tartarus.org/index.php | Major events | | September 2014 - Snowball site and software no longer being | actively maintained | The code has all been loaded into Github, and we may still | make very occasional changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review