https://bugzilla.redhat.com/show_bug.cgi?id=1183169 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- Hi, A few notes : - you should use macro for various path ( /usr/lib/systemd/system for example ) - i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff ) - if it install a service, it should run some scriplet for systemd, no ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review