[Bug 1144802] Review Request: globus-xio-rate-driver - Globus Toolkit - Globus XIO Rate Limiting Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1144802



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Mattias Ellert from comment #2)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> 
> Many thanks for taking on the review!
> 
> > The same as #1181118:
> > 5. %description reads like an advertisement.
...
> 
> The first part of the description is taken from upstream's website
...
I'll reply to that in #1181118. Whatever resolution is reached there,
should apply here too.

> > 8. %files should have (note extra dot)
> > %{_libdir}/libglobus_net_manager.so.*
> 
> This looks like a cut and paste error from the globus-net-manager review.
Sorry. I was trying to build and review too many things in parallel.

The issue here is different:
this package contains an unversioned .so file in %{_libdir}. It
should either be versioned, or be moved to a private directory which
is not search by ldconfig.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]