https://bugzilla.redhat.com/show_bug.cgi?id=1180723 --- Comment #7 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- No, again the point is that it is very difficult for other people including me to read your spec file. Even if you comment on your macros, readability does not get better. Other people may touch your spec file after you import your spec file into Fedora git, e.g. on mass rebuild. In that case we have to expand macros you introduced. Especially: - many %clufter_foo definition - unusual %changelog - needless %foo_description makes this spec file very hard to read. You think you want to remove redundancy and while I want to understand it the current difficulty to read must be fixed in the first place. Please follow what other people writes spec files. More explicitly: - Write %changelog in an usual way - Remove use %clufter_foo and expand them - Remove unneeded %foo_description . Anyway you need not write duplicate description in subpackages. Write main description only on "main" package. - Remove clufter_bashcomp clufter_script conditional. These are not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review