https://bugzilla.redhat.com/show_bug.cgi?id=1144800 --- Comment #4 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > 1. %setup -q -n %{_name}-%{version} --> %setup -q No "%setup -q" is equivalent to "%setup -q -n %{name}-%{version}", not to "%setup -q -n %{_name}-%{version}" > 2. It installs an unversioned .so file in %_libdir. Yes. As I wrote in the review request - this is a plugin. It is not intended for linking, but for dynamic loading using dlopen. Since it is a plugin it is compiled using -module -avoid-version, and it is loaded at runtime referring to the unversioned name. The software that loads these plugins expects to find them in the default library path. > The same as #1181118: > 5. %description reads like an advertisement. It should at least mention what > "grid" is. Who develops it is not crucial. Also the last paragraph "The > %{name package contains..." is not really useful, since it repeats the > Summary. The first part of the description is taken from upstream's website http://toolkit.globus.org/toolkit/. It is upstream's own description of the software, so I think it is relevant. The same sentence appears in the description of the 50+ Globus Toolkit packages that already exists in Fedora. I can recognize that grid is not the same hype and buzz word it was 5-10 years ago, but the meaning of the word hasn't changed. Is it really forgotten to the extent that it is not possible to use it anymore? I should probably expand ePPN to eduPersonPrincipalName in the long description. > 9. where does Source8 come from? I am not sure what you are asking here. There is no upstream source for this file anywhere. It is a collection of links to the upstream online documentation compiled for the purpose of creating the package. Since the upstream project groups their packages and provide documentation per group, all packages in the same group have the same README file, so in this case it was copied from an other package in the GSIC group. These files were added to the packages in order to address complaints about missing documentation. Updated version: Spec URL: http://www.grid.tsl.uu.se/review/globus-gridmap-eppn-callout.spec SRPM URL: http://www.grid.tsl.uu.se/review/globus-gridmap-eppn-callout-1.7-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review