[Bug 979124] Review Request: qbs - Qt Build Suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979124



--- Comment #71 from Jake Petroules <jake.petroules@xxxxxxxxxxxxx> ---
> Also you said that modules are fine to be removed :P

Some... it depends. Hence my concerns against using this pattern.

> Though I am of course open for further discussions ;) In case you (upstream) somewhen plan to introduce modules which cannot be removed easily (what I do not hope). I would need to reconsider this...

We've essentially already done so. In 1.4 the bundle module is only used on OS
X and iOS but removing it would break all normal builds even on other
platforms. It's fine for "unused" files to just go in the main package for now.

> @autotests:
Well it _is_ possible to run the tests, but since I seem to be the only one who
runs the tests in such a setup I always hit issues when you do changes
upstream. For example my old setup stopped working due to some changes and
understanding why it stopped working + then opening a bugreport about it (or do
countless builds to test it on my end) is a bit annoying for me at the moment.

If it's our fault, it's our fault. Report bugs and we'll fix them. If the tests
are actually working, then they should absolutely be run as part of the rpm
build.

We can maybe try to better police ourselves by testing with more
configurations, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]