Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Crypt-OpenSSL-DSA -- Perl OpenSSL bindings for DSA support -- SPONSOR NEEDED https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237333 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-10 01:22 EST ------- Source0: URL is incorrect; should be http://search.cpan.org/CPAN/authors/id/T/TJ/TJMATHER/Crypt-OpenSSL-DSA-%{version}.tar.gz I find it useful to run spectool -g just to make sure that the Source URLs in the spec can be fetched without error. Blah BuildRequires: perl(ExtUtils::MakeMaker) blah. Annoying, isn't it? But as soon as F7 branches, perl will lose the perl-devel dependency things packages that don't pull in all of their build-time requirements will break, so we're trying to catch them all in review and prevent pain later. And again I'm not sure whether you'll need perl(Test) or not. You get better test coverage if you have a build-time dependency on perl(Digest::SHA1). The package itself doesn't use it, but one of the tests does. * source files match upstream: f786a76441106a6ce3de4d153bddd3fc0a8a90657b2cb6778aa362e4e7d66cef Crypt-OpenSSL-DSA-0.13.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. X BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: DSA.so()(64bit) perl(Crypt::OpenSSL::DSA) = 0.13 perl-Crypt-OpenSSL-DSA = 0.13-2.fc7 = libcrypto.so.6()(64bit) libssl.so.6()(64bit) perl(:MODULE_COMPAT_5.8.8) perl(DynaLoader) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: (with a build dependency on Digest::SHA1 added) All tests successful. Files=3, Tests=115, 1 wallclock secs ( 0.62 cusr + 0.18 csys = 0.80 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la droppings. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review