https://bugzilla.redhat.com/show_bug.cgi?id=1180058 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- A rename review of existing kde-plasma-nm package, so should be pretty straight-forward. sources: ok 85bcbb4dc40ff020a566413a209858ca plasma-nm-5.1.2.tar.xz Upgrade path: ok Obsoletes: kde-plasma-networkmanagement < 1:0.9.1.0 Obsoletes: kde-plasma-networkmanagement-libs < 1:0.9.1.0 Obsoletes: kde-plasma-nm < 5.0.0-1 1. SHOULD consider adding Provides: at least for kde-plasma-nm, e.g. Provides = kde-plasma-nm = %{version}-%{release} 2. SHOULD re-add this snippet in -mobile pkg from kde-plasma-nm: %if 0%{?fedora} > 20 Requires: NetworkManager-wwan >= 0.9.8 %endif Otherwise, looks good, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review