Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: audacious-itouch - iTouch keyboard control plugin for the Audacious media player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218256 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium ------- Additional Comments From lightsolphoenix@xxxxxxxxx 2007-05-09 17:20 EST ------- > I agree the plugin should be named audacious-plugin-itouch. > But to do this, I must modify the source tarbal, and repackage > it. Do I have the right to do that? Nah, you don't have to. %setup accepts a switch, -n, which allows for changing the exact name of the folder in the source tarball. In this case, simply change to this: %setup -q -n audacious-itouch-%{version} Quick Review (not official): Since I can't download the source, this is just going to be a quick runthrough. MUST Items: - rpmlint gives no errors. - The package is named according to the Package Naming Guidelines. - The package is licenced under an open-source licence (GPL). - Licence info included in %doc. - Spec file named %{name}.spec. - Spec file written in en-US and is legible. - The package compiles on i386. - Build dependencies are listed in BuildRequires properly. - No locales in the package. - ldconfig isn't called, but the library is not located in the standard linker path. - Package is not relocatable. - Package owns all directories it creates. - Permissions on files are set properly. - Package has a proper %clean section. - Spec file uses consistent macros. - Package contains permissible content. - All files in %doc are not necessary for program application. - .la files are properly removed. - Package does not create it's own directories. - Package runs %{__rm} -rf %{buildroot} at the beginning of install. - All filenames are valid UTF-8. Possible problems: - As mentioned before, the package should probably be called audacious-plugins-itouch. - The Source entry is actually a 404 now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review