https://bugzilla.redhat.com/show_bug.cgi?id=1179172 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. SHOULD omit "5" from pkg Summary , ie Summary: Plasma Desktop less worries when/if Plasma 6 appears, or maybe just not worry that far ahead :) sources: ok 8a01835179b25e3a7ff644fd7e52ec96 plasma-workspace-5.1.2.tar.xz 2. SHOULD drop %config here %config %{_sysconfdir}/xdg/*.knsrc %config %{_sysconfdir}/xdg/autostart/*.desktop stuff under /etc/xdg is generally not meant for %config really 3. SHOULD move these to main pkg (from -devel): %{_datadir}/dbus-1/interfaces/*.xml scriptlets: NOT ok 4. MUST validate application .desktop files %{_datadir}/applications/*.desktop macros: ok stuff to look into post-review (not review blockers): * SHOULD be owned by kde-settings instead, but can deal with that post-review %config %{_sysconfdir}/pam.d/kde * don't hard-code Requires: sddm , and then probably subpkg or own parent dirs of: %{_datadir}/sddm/themes/breeze -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review