https://bugzilla.redhat.com/show_bug.cgi?id=1179217 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. this part in -devel %{_kf5_datadir}/dbus-1/interfaces/org.kde.baloo.file.indexer.xml looks like it SHOULD be in -file subpkg instead naming: ok sources: ok a8ddea44b89176530b6598231ff89c43 baloo-5.1.2.tar.xz 2. SHOULD consider dropping -tools subpkg, these aren't big so why split them out? scriptlets: NOT ok 3. main pkg contains %{_kf5_datadir}/icons/hicolor/*/apps/baloo.png MUST add icon cache scriptlets macros: ok 4. -devel subpkg uses deprecated Group: tag, SHOULD remove it -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review