[Bug 1178934] Review Request: perl-Exporter-Tidy - Another way of exporting symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1178934

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Source file is original (SHA-256:
7e8472c32b1e47d0d90dfb517c039281246c3a52be3022e3cfd57a9fb9e4e58b).

There are no changes in the source except $VERSION bump, README, META files,
and MANIFEST.

SPEC file changes:

--- perl-Exporter-Tidy.spec.old 2015-01-05 17:56:12.000000000 +0100
+++ perl-Exporter-Tidy.spec     2015-01-06 14:52:23.000000000 +0100
@@ -1,8 +1,9 @@
 Name:           perl-Exporter-Tidy
-Version:        0.07
+Version:        0.08
 Release:        1%{?dist}
 Summary:        Another way of exporting symbols
-License:        Public Domain
+# Generated with licenses.pl
+License:        AAL or AFL or AGPLv3 or APSL 2.0 or ASL 2.0 or Artistic 2.0 or
BSD or Boost or CATOSL or CDDL or CNRI or CPAL or CeCILL or ECL 2.0 or EFL 2.0
or EPL or EU Datagrid or EUPL 1.1 or Entessa or Fair or GPLv2 or GPLv3 or IBM
or IPA or ISC or LGPLv2 or LGPLv3 or LPL or LPPL or MIT or MPLv1.1 or MPLv2.0
or MS-PL or MS-RL or MirOS or Motosoto or NCSA or NGPL or Naumen or Nokia or
OFL or OSL 3.0 or PHP or PostgreSQL or Python or QPL or RPSL or SPL or
Sleepycat or VSL or W3C or ZPLv2.0 or zlib
 URL:            http://search.cpan.org/dist/Exporter-Tidy/
 Source0:       
http://www.cpan.org/authors/id/J/JU/JUERD/Exporter-Tidy-%{version}.tar.gz
 BuildArch:      noarch
@@ -16,7 +17,6 @@
 BuildRequires:  perl(Exporter)
 BuildRequires:  perl(lib)
 BuildRequires:  perl(strict)
-BuildRequires:  perl(Test::More)
 BuildRequires:  perl(threads)
 BuildRequires:  perl(threads::shared)
 BuildRequires:  perl(vars)
@@ -48,5 +48,8 @@
 %{_mandir}/man3/*

 %changelog
-* Mon Jan 05 2015 Petr Šabata <contyk@xxxxxxxxxx> 0.07-1
+* Tue Jan 06 2015 Petr Šabata <contyk@xxxxxxxxxx> - 0.08-1
+- 0.08 bump
+
+* Mon Jan 05 2015 Petr Šabata <contyk@xxxxxxxxxx> - 0.07-1
 - Initial packaging


> TODO: Insert some statement into the description that this is about Perl.
> E.g. "This Perl module serves".
Not addressed. Ok.

> TODO: Remove bundled Test::More and Test::Builder from t/lib to use system
> ones when running tests.
Not addressed. Ok.

> FIX: The README states "public domain", but the Tidy.pm stats:
README and License tag fixed. Ok.

> FIX: Do not build-require Test::More, or remove the bundled module and do
> not build-require its dependencies.
-BuildRequires:  perl(Test::More)
Ok.

$ rpmlint perl-Exporter-Tidy.spec
../SRPMS/perl-Exporter-Tidy-0.08-1.fc22.src.rpm
../RPMS/noarch/perl-Exporter-Tidy-0.08-1.fc22.noarch.rpm 
perl-Exporter-Tidy.src: W: spelling-error %description -l en_US subclassed ->
sub classed, sub-classed, subclass ed
perl-Exporter-Tidy.src: W: spelling-error %description -l en_US namespace ->
name space, name-space, names pace
perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US subclassed
-> sub classed, sub-classed, subclass ed
perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US namespace ->
name space, name-space, names pace
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

Package builds in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=8540391). Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]