https://bugzilla.redhat.com/show_bug.cgi?id=1179233 --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- Missing BRs: - perl, called in the SPEC - perl(base), Combinatorics.pm:14 - perl(Carp), Combinatorics.pm:11 - perl(Exporter), Combinatorics.pm:13-14 - perl(FindBin), t/* - perl(lib), t/* - perl(strict), Makefile.PL:1, Combinatorics.pm:4, t/* - perl(warnings), Makefile.PL:2, t/* - perl(XSLoader), Combinatorics.pm:8 Test::More is only used at build-time; there's no point in requiring it at runtime. Scalar::Util will be autodetected by rpmbuild; no need to require it explicitly. The following line is unnecessary: find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; The %description points to a section in POD which isn't available in the RPM metadata. Remove that note. Consider using DESTDIR instead of PERL_INSTALL_ROOT. If you're building only for F21+, you can raise the minimum EU::MM requirement to 6.76 and utilize the NO_PACKLIST feature; this would save you another line in %install. Consider packaging the benchmarks in %doc; the distribution POD mentions them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review