[Bug 1172719] Review Request: isl - Integer point manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1172719

Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |bugs.michael@xxxxxxx
              Flags|                            |fedora-review+



--- Comment #8 from Michael Schwendt <bugs.michael@xxxxxxx> ---
* There's a test-suite included, which could be run in %check. It is successful
here:

--- isl.spec.orig    2015-01-05 17:31:50.000000000 +0100
+++ isl.spec    2015-01-06 13:42:13.608267534 +0100
@@ -62,6 +62,9 @@
 mkdir -p %{buildroot}/%{gdbprettydir}
 mv %{buildroot}/%{_libdir}/*-gdb.py* %{buildroot}/%{gdbprettydir}

+%check
+make check
+
 %post -p /sbin/ldconfig
 %postun -p /sbin/ldconfig



* "fedora-review -b 1172719" doesn't find any issue either. The GPLv2+ license
it recognizes is only in libtool's ltmain.sh.


* Modern packaging guidelines prefer %global over %define:
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define


* APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]