Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: machineball - A futuristic ball game with simple rules https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238562 mr.ecik@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From mr.ecik@xxxxxxxxx 2007-05-09 11:57 EST ------- REVIEW: * rpmlint is quiet !* missing BR: mesa-libGLU-devel * licensed under GPL license and its text's included * required %post(un) supplied * dist tag present !* no macros in Source0 tag * buildroot's fine * package doesn't create any new directories * proper permissions of all files * desktop file seems fine * %clean section is fine * source's md5sum is good, but !* curiously enough, its name is different than the offical one. Adding %{version} tag should fix that problem THINGS TO DO: - add missing BR: mesa-libGLU-devel - add at least %{version} to Source0 tag - upload proper source code file to srpm (current one has a wrong name) The last issue forces change of versioning. Probably you can just replace "-" with ".", but if aby other (better) ideas are very welcome. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review