[Bug 1172719] Review Request: isl - Integer point manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1172719



--- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> ---
[relinking with -lgmp]

> True, but it also shouldn't hurt.

It can lead to extra rebuilds, e.g. you would need to rebuild anything that
links with -lisl, if only GMP bumped its SONAME. Being aware of that can be
helpful. Often the pkgconfig files are tailored for static linking.



> I'm not sure what I can do about that without modifying the gmp package.

The added "Requires: gmp-devel" is almost the right fix. You really want
"Requires: gpm-devel%{?_isa}" to get the correct build-arch.


> I have a line that supposedly removes that in the spec file and
> I don't see it when I build the RPMs.

The added lines are the right fix. Note that "rm -f" would be better, because
unlike "rm" it would not make the build fail, if the file to be removed does
not exist. => You want to get rid of the file anyway, so if it doesn't exist
that's fine.


> Did you mean %make_install instead?

Yes. The macro saves some typing, but it's not a MUST.


You've not fixed/removed the Group tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]