[Bug 1178361] Review Request: stuntrally - Stunt Rally game with Track Editor, based on VDrift and OGRE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1178361



--- Comment #2 from MartinKG <mgansser@xxxxxxxx> ---
upload new spec file, no SRPMS file due to size of approx. 900 MB:
Spec URL:
https://martinkg.fedorapeople.org/Review/stuntrally-2.5-2/stuntrally.spec

I made also a review template with:
fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -rn
../SRPMS/stuntrally-2.5-2.fc21.src.rpm
https://martinkg.fedorapeople.org/Review/review-template/stuntrally/review.txt

%changelog
* Sun Jan 04 2015 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 2.5-2
- fix wrong-script-end-of-line-encoding
- added BR desktop-file-utils
- added static subpackage

rpmlint output:
Checking: stuntrally-2.5-2.fc22.x86_64.rpm
          stuntrally-devel-2.5-2.fc22.x86_64.rpm
          stuntrally-static-2.5-2.fc22.x86_64.rpm
          stuntrally-data-2.5-2.fc22.noarch.rpm
          stuntrally-2.5-2.fc22.src.rpm
stuntrally.x86_64: W: no-manual-page-for-binary stuntrally
stuntrally.x86_64: W: no-manual-page-for-binary sr-editor
stuntrally-devel.x86_64: W: spelling-error %description -l en_US shiny's ->
shin's, shine's, shiny
stuntrally-devel.x86_64: W: no-documentation
stuntrally-static.x86_64: W: no-documentation
stuntrally-data.noarch: W: no-documentation
stuntrally.src:132: E: hardcoded-library-path in %{_prefix}/lib/OGRE/
stuntrally.src:133: E: hardcoded-library-path in %{_prefix}/lib/libshiny.a
stuntrally.src: W: invalid-url Source1:
https_1://github.com/stuntrally/tracks/archive/2.5/tracks-2.5.tar.gz
stuntrally.src: W: invalid-url Source0:
https_1://github.com/stuntrally/stuntrally/archive/2.5/stuntrally-2.5.tar.gz
5 packages and 0 specfiles checked; 2 errors, 8 warnings.


does the fonts can remain in the package ?
Generic:
[ ]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files

stuntrally includes the following truetype fonts:

/usr/share/stuntrally/fonts/DejaVuLGCSans.ttf
/usr/share/stuntrally/fonts/LiberationSans-BoldItalic.ttf
/usr/share/stuntrally/fonts/Vera.ttf
/usr/share/stuntrally/fonts/VeraMono.ttf

this fonts a also available with yum for fedora:
dejavu-lgc-sans-fonts.noarch : Variable-width sans-serif font faces,
Latin-Greek-Cyrillic subset
liberation-sans-fonts.noarch : Sans-serif fonts to replace commonly used
Microsoft Arial
bitstream-vera-fonts-common.noarch : Common files of the Bitstream Vera font
set
bitstream-vera-sans-mono-fonts.noarch : Monospace sans-serif Bitstream Vera
fonts

how can we deal with this ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]