https://bugzilla.redhat.com/show_bug.cgi?id=1175299 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok (though I'd prefer to use the upstream name here: libksysguard) sources: ok 05edba7e9c155008e8b26d15756b355c libksysguard-5.1.1.tar.xz 1. SHOULD use better project url, suggest URL: https://projects.kde.org/projects/kde/workspace/libksysguard macros: ok (mostly...) 2. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} over %make_install scriptlets: ok no MUST blockers, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review