https://bugzilla.redhat.com/show_bug.cgi?id=1175323 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jgrulich@xxxxxxxxxx Flags| |needinfo?(jgrulich@redhat.c | |om) --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok (mostly) 1. another pkg where I'm not fond of using an artificial plasma- prefix, SHOULD consider removing it. 2. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} -C %{_target_platform} over %make_install -C %{_target_platform} 3. MUST validate application .desktop file, add BuildRequires: desktop-file-utils and %check desktop-file-validate %{buildroot}%{_datadir}/applications/kdesystemsettings.desktop desktop-file-validate %{buildroot}%{_datadir}/applications/systemsettings.desktop 4. SHOULD use %find_lang ... --with-kde ... to automatically pick up HTML handbooks 5. SHOULD use better project url URL: https://projects.kde.org/projects/kde/workspace/systemsettings sources: ok bb382e4c5b97a4ed8c8e116567247a83 systemsettings-5.1.1.tar.xz license: ok -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review