https://bugzilla.redhat.com/show_bug.cgi?id=1135503 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dvratil@xxxxxxxxxx Flags| |needinfo?(dvratil@xxxxxxxxx | |m) --- Comment #11 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok 1. though SHOULD use better project url: URL: https://projects.kde.org/projects/kde/workspace/khelpcenter 2. SHOULD consider dropping needless scriptlets: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig though I'm not sure if %{_kf5_libdir}/libkdeinit5_khelpcenter.so counts as a shared library in this circumstance or not. 3. SHOULD use %find_lang ... --with-kde ... then it should automatically pick up the HTML handbook stuff too 4. SHOULD prefer/use make install/fast DESTDIR=%{buildroot} over %make_install 5. MUST validate application .desktop file %{_datadir}/applications/Help.desktop suggest adding BuildRequires: desktop-file-utils and %check desktop-file-validate %{buildroot}%{_datadir}/applications/Help.desktop 6. SHOULD consider shipping %{_kde4_datadir}/kde4/services/khelpcenter.desktop %{_kde4_datadir}/services/khelpcenter.desktop to provide services for kde4/kde3 runtimes too (like kde-runtime-4's khelpcenter pkg does) 7. license: NOT ok there's a mix of GPLv2+ and GPLv2 or GPLv3 so MUST fix license tag, I'd suggest: License: GPLv2 or GPLv3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review