Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ddccontrol - TFT monitor parameters control https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238248 kmatsui@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmatsui@xxxxxxxxxxxx ------- Additional Comments From kmatsui@xxxxxxxxxxxx 2007-05-09 05:26 EST ------- I am not yet a package-maintainer. This is my "pre-review" to exercise reviewing. rpmbuild builds rpms successfully from the source with ddccontrol.spec, and rpm -i installs the generated binary rpms (libddccontrol, ddccontrol, ddccontrol-applet) successfully. mock, however, ends with errors. This is due to lack of gettext in BuildRequires. Adding this to the spec file, mock builds rpms successfully. rpmlint says on ddccontrol-0.4.2-1.fc6.src.rpm: --------------------start here--------------------- W: ddccontrol non-standard-group System/Configuration/Hardware The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support". W: ddccontrol hardcoded-path-in-buildroot-tag /var/tmp/%{name}-buildroot A path is hardcoded in your Buildroot tag. It should be replaced by something like %{_tmppath}/%name-root. E: ddccontrol no-cleaning-of-buildroot %install You should clean $RPM_BUILD_ROOT in the %clean section and just after the beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT". E: ddccontrol no-cleaning-of-buildroot %clean You should clean $RPM_BUILD_ROOT in the %clean section and just after the beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT". W: ddccontrol no-%clean-section The spec file doesn't contain a %clean section to remove the files installed by the %install section. --------------------end here------------------------ rpmlint says on the generated ddccontrol-0.4.2-1.fc6.i368.rpm: (Hereafter, I remove the same message about grouping above.) --------------------start here--------------------- E: ddccontrol standard-dir-owned-by-package /usr/share/man/man1 This package owns a directory that is part of the standard hierarchy, which can lead to default directory permissions or ownerships being changed to something non-standard. E: ddccontrol setuid-binary /usr/bin/ddcpci root 04711 The file is setuid, this may be dangerous, especially if this file is setuid root. E: ddccontrol non-standard-executable-perm /usr/bin/ddcpci 04711 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. W: ddccontrol incoherent-version-in-changelog 0.4.2-alt2 0.4.2-1.fc6 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. W: ddccontrol unstripped-binary-or-object /usr/bin/ddccontrol W: ddccontrol unstripped-binary-or-object /usr/bin/ddcpci W: ddccontrol unstripped-binary-or-object /usr/bin/gddccontrol W: ddccontrol one-line-command-in-%post #%update_menus You should use %post -p <command> instead of using: %post <command> It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command for the excecution of the scriptlet. W: ddccontrol one-line-command-in-%postun #%clean_menus You should use %postun -p <command> instead of using: %postun <command> It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command for the excecution of the scriptlet. --------------------end here------------------------ rpmlint says on the generated ddccontrol-applet-0.4.2-1.fc6.i368.rpm: --------------------start here--------------------- W: ddccontrol-applet no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. W: ddccontrol-applet unstripped-binary-or-object /usr/lib/ddccontrol/ddcc-applet --------------------end here------------------------ rpmlint says on the generated libddccontrol-0.4.2-1.fc6.i368.rpm: --------------------start here--------------------- W: libddccontrol no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. W: libddccontrol unstripped-binary-or-object /usr/lib/libddccontrol.so.0.0.0 --------------------end here------------------------ Refer to: http://fedoraproject.org/wiki/Packaging/Guidelines Please rewrite the spec file first. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review